Demo of code to perform retries, internal to the Api object. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrrh
reviewed
Aug 9, 2017
| @@ -15,6 +16,10 @@ | |||
| } | |||
| NAMESPACE = "http://api.namecheap.com/xml.response" | |||
|
|
|||
| # default values for the retry mechanism | |||
There was a problem hiding this comment.
I would like to rework those "retries" as "attempts" to replace following while True conditional with while attempts > 0, which looks more readable for me.
There was a problem hiding this comment.
Sure thing! ... shall I provide additional commits to this PR, or do you have another preference?
(if you haven't guessed, I'm totally easy :-) ... and deferential to your design/goals for PyNamecheap)
There was a problem hiding this comment.
Oh. Merged already ... 📦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my thinking on how to do retries within the Api object, related to issue #8
Some additional comments and debug code could/should be added (if you like this approach). And the Api class has new parameters to document in README.md